Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26167] Android: Fixed TextField/TextArea focus/blur handling #10145

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

jquick-axway
Copy link
Contributor

JIRA:

Summary:


Testing TextField/TextArea/ScrollView handling:

  1. Build and run the test code attached to TIMOB-26167 on Android.
  2. On app startup, verify that the virtual keyboard does not pop-up. (This verifies that a TextField/TextArea is no longer auto-focused on startup for TIMOB-24138.)
  3. Tap on a multiline TextArea.
  4. Verify that you can edit the TextArea.
  5. Scroll down to the very bottom.
  6. Tap on a single-line TextField.
  7. Verify that you can edit the TextField.

Testing "focus" and "blur" event bubbling:

  1. Build and run the test code attached to TIMOB-26172 on Android.
  2. Follow that ticket's test procedure, but this time verify the event's bubbles property is now false.
  3. Verify that the window does not receive "focus" or "blur" events bubbled from the TextField. (Note that you will receive 1 "focus" event from the window on startup and this is normal.)

Testing ScrollView focus issue for TIMOB-25819:

  1. Build and run the below code on Android.
  2. Verify that the window is completely green. (If you see any red, then the test failed.)
  3. Scroll down (by flinging up) and verify that you see a red view.
var window = Ti.UI.createWindow();
var scrollView = Ti.UI.createScrollView({
	layout: "vertical",
	scrollType: "vertical",
	showHorizontalScrollIndicator: false,
	shorVerticalScrollIndicator: true,
	width: Ti.UI.FILL,
	height: Ti.UI.FILL,
});
scrollView.add(Ti.UI.createView({
	backgroundColor: "green",
	width: Ti.UI.FILL,
	height: "100%",
}));
scrollView.add(Ti.UI.createListView({
	backgroundColor: "red",
	width: Ti.UI.FILL,
	height: "100%",
}));
window.add(scrollView);
window.open();

- Fixed bug where TextField/TextArea cannot be edited while in a ScrollView. (Introduced in 7.3.0.)
- Fixed [TIMOB-26172] where a view's "focus" and "blur" events should not bubble to parent views, like iOS.
- TextField/TextArea and other focusable views no longer receive focus by default when opening a window, like iOS.
  * Resolves tickets [TIMOB-8637], [TIMOB-24138], and [TIMOB-25819].
@build
Copy link
Contributor

build commented Jun 30, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants