[TIMOB-25836] : iOS Using "run-on-main-thread", multiple global event listeners do not work #9908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… listeners do not work
|
Please add unit tests for this. I think the example from JIRA will geko already, together with a finish() |
hansemannn
reviewed
Mar 6, 2018
| @@ -188,7 +188,7 @@ - (void)fireEvent:(NSArray *)args | |||
|
|
|||
| DebugLog(@"[DEBUG] Firing app event: %@", type); | |||
|
|
|||
| NSArray *array = [appListeners objectForKey:type]; | |||
| NSArray *array = [[appListeners objectForKey:type] copy]; | |||
There was a problem hiding this comment.
I wonder if we should rather synchronize the appListeners setters, so nothing can be mutated during its write-process.
There was a problem hiding this comment.
I think it will slow the processing. And if there are not more use cases like this, we should avoid.
There was a problem hiding this comment.
Ok then, taking your word!
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25836