Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25836] : iOS Using "run-on-main-thread", multiple global event listeners do not work #9908

Merged
merged 9 commits into from
May 21, 2018
Merged

[TIMOB-25836] : iOS Using "run-on-main-thread", multiple global event listeners do not work #9908

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9fa98fe
[TIMOB-25836] : iOS Using "run-on-main-thread", multiple global event…
vijaysingh-axway Mar 6, 2018
3f0bfe8
[TIMOB-25836] : Unit test added
vijaysingh-axway Mar 8, 2018
8b1fd03
[TIMOB-25836] : Linting issue fixed
vijaysingh-axway Mar 8, 2018
4894aa8
[TIMOB-25836] : Fixed lint issue
vijaysingh-axway Mar 8, 2018
743ac10
[TIMOB-25836] : Lint issue
vijaysingh-axway Mar 8, 2018
4702e1f
[TIMOB-25836]:Lint issue fix
vijaysingh-axway Mar 8, 2018
cc0a144
Merge branch 'master' into TIMOB-25836
vijaysingh-axway Mar 8, 2018
a5b2e89
Merge branch 'master' into TIMOB-25836
hansemannn Mar 9, 2018
d3097c3
Merge branch 'master' into TIMOB-25836
hansemannn May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion iphone/Classes/AppModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ - (void)fireEvent:(NSArray *)args

DebugLog(@"[DEBUG] Firing app event: %@", type);

NSArray *array = [appListeners objectForKey:type];
NSArray *array = [[appListeners objectForKey:type] copy];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should rather synchronize the appListeners setters, so nothing can be mutated during its write-process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will slow the processing. And if there are not more use cases like this, we should avoid.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then, taking your word!


if (array != nil && [array count] > 0) {
NSMutableDictionary *eventObject = nil;
Expand All @@ -208,6 +208,7 @@ - (void)fireEvent:(NSArray *)args
// fire application level event
[host fireEvent:[entry listener] withObject:jsonObject remove:NO context:[entry context] thisObject:nil];
}
[array release];
}
}
}
Expand Down