[TIMOB-16511] : Text in label gets truncated (...) when changing font Weight from normal to bold #9923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Weight from normal to bold
Generated by 🚫 dangerJS |
hansemannn
reviewed
Mar 9, 2018
| @@ -448,6 +448,7 @@ - (void)setFont_:(id)font | |||
| CGFloat ratio = minFontSize / label.font.pointSize; | |||
| [label setMinimumScaleFactor:ratio]; | |||
| } | |||
| [self padLabel]; | |||
There was a problem hiding this comment.
This is a pretty major change. Can we validate the following use-cases for this:
- Multi-line labels
- ellipsize labels
- minimum-font-sizes
There was a problem hiding this comment.
Right, changing other label properties causes this issue too. Our label code probably needs to re-udpate/invalidate itself after a property change.
https://jira.appcelerator.org/browse/TIMOB-24864
hansemannn
approved these changes
Mar 9, 2018
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-16511