Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-16511] : Text in label gets truncated (...) when changing font Weight from normal to bold #9923

Merged
merged 4 commits into from
Jun 30, 2018
Merged

[TIMOB-16511] : Text in label gets truncated (...) when changing font Weight from normal to bold #9923

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f35a773
[TIMOB-16511] : Text in label gets truncated (...) when changing font…
vijaysingh-axway Mar 9, 2018
9989ae0
Merge branch 'master' into TIMOB-16511
vijaysingh-axway Mar 9, 2018
c542a6c
Merge branch 'master' into TIMOB-16511
vijaysingh-axway Jun 7, 2018
0bb44f7
Merge branch 'master' into TIMOB-16511
hansemannn Jun 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions iphone/Classes/TiUILabel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ - (void)setFont_:(id)font
CGFloat ratio = minFontSize / label.font.pointSize;
[label setMinimumScaleFactor:ratio];
}
[self padLabel];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty major change. Can we validate the following use-cases for this:

  • Multi-line labels
  • ellipsize labels
  • minimum-font-sizes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, changing other label properties causes this issue too. Our label code probably needs to re-udpate/invalidate itself after a property change.
https://jira.appcelerator.org/browse/TIMOB-24864

[(TiViewProxy *)[self proxy] contentsWillChange];
}

Expand Down