Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25913] Android: Update gradle for Java 9 compatibility #9971

Merged
merged 3 commits into from Apr 3, 2018
Merged

[TIMOB-25913] Android: Update gradle for Java 9 compatibility #9971

merged 3 commits into from Apr 3, 2018

Conversation

garymathews
Copy link
Contributor

  • Update gradle to 4.6 for Java 9 compatibility

JIRA Ticket

@garymathews garymathews added this to the 7.2.0 milestone Mar 28, 2018
@garymathews garymathews mentioned this pull request Mar 28, 2018
Merged
@build
Copy link
Contributor

build commented Mar 28, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

NOTE: #9964 needs to be merged first as it has the CLI detection fix for JDK 9 & 10 included inside node-appc@0.2.45.

@jquick-axway
Copy link
Contributor

@lokeshchdhry,

We need to test this change with the test attached to ticket: TIMOB-25597

FYI: We're always running gradle and proguard for every Android build, but the above test verifies that the proguard multidexing results actually works on an Android 4.x device.

jquick-axway
jquick-axway approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Apr 2, 2018 •
edited

FR Passes.

No java.time.DateTimeException seen with java 9.0.4 & crittercism. Build works fine.

@jquick-axway , Thanks for the suggestion. Tried test case in https://jira.appcelerator.org/browse/TIMOB-25597 & it worked fine with android 4.X.

Studio Ver: 5.1.0
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.3
Appc NPM: 4.2.12
Appc CLI: 7.0.3-master.24
Daemon Ver: 1.0.1
Ti CLI Ver: 5.1.0
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 9.0.4
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1
Emulator: Android 4.1

@hansemannn hansemannn merged commit 783dfc1 into tidev:master Apr 3, 2018
build pushed a commit to garymathews/titanium_mobile that referenced this pull request Apr 23, 2018
@garymathews @sgtcoolguy
[TIMOB-25913] Update gradle for Java 9 compatibility (tidev#9971)
d827d7b
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @build @lokeshchdhry @jquick-axway @sgtcoolguy @hansemannn