-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25913] Android: Update gradle for Java 9 compatibility #9971
Conversation
Generated by 🚫 dangerJS |
NOTE: #9964 needs to be merged first as it has the CLI detection fix for JDK 9 & 10 included inside node-appc@0.2.45. |
We need to test this change with the test attached to ticket: TIMOB-25597 FYI: We're always running gradle and proguard for every Android build, but the above test verifies that the proguard multidexing results actually works on an Android 4.x device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
FR Passes. No @jquick-axway , Thanks for the suggestion. Tried test case in https://jira.appcelerator.org/browse/TIMOB-25597 & it worked fine with android 4.X. Studio Ver: 5.1.0 |
gradle
to4.6
for Java 9 compatibilityJIRA Ticket