♻️ Omit analytics from test/preview pushes

appcues · May 6, 2024 · bc29bb3 · bc29bb3
1 parent 75e30c2
commit bc29bb3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/Sources/AppcuesKit/Push/ParsedNotification.swift b/Sources/AppcuesKit/Push/ParsedNotification.swift
@@ -42,7 +42,7 @@ internal struct ParsedNotification {
         self.attachmentURL = (userInfo["appcues_attachment_url"] as? String)
             .flatMap { URL(string: $0) }
         self.attachmentType = userInfo["appcues_attachment_type"] as? String
-        self.isTest = userInfo["appcues_test"] as? Bool ?? false
+        self.isTest = userInfo["appcues_test"] != nil
         self.isInternal = userInfo["_appcues_internal"] as? Bool ?? false
     }
 }
diff --git a/Sources/AppcuesKit/Push/PushMonitor.swift b/Sources/AppcuesKit/Push/PushMonitor.swift
@@ -160,17 +160,19 @@ internal class PushMonitor: PushMonitoring {
         parsedNotification: ParsedNotification,
         completionHandler: @escaping () -> Void
     ) {
-        analyticsPublisher.publish(TrackingUpdate(
-            type: .event(name: Events.Push.pushOpened.rawValue, interactive: false),
-            properties: [
-                "notification_id": parsedNotification.notificationID,
-                "workflow_id": parsedNotification.workflowID,
-                "workflow_task_id": parsedNotification.workflowTaskID,
-                "transaction_id": parsedNotification.transactionID,
-                "device_id": storage.deviceID
-            ].compactMapValues { $0 },
-            isInternal: true
-        ))
+        if !parsedNotification.isTest {
+            analyticsPublisher.publish(TrackingUpdate(
+                type: .event(name: Events.Push.pushOpened.rawValue, interactive: false),
+                properties: [
+                    "notification_id": parsedNotification.notificationID,
+                    "workflow_id": parsedNotification.workflowID,
+                    "workflow_task_id": parsedNotification.workflowTaskID,
+                    "transaction_id": parsedNotification.transactionID,
+                    "device_id": storage.deviceID
+                ].compactMapValues { $0 },
+                isInternal: true
+            ))
+        }
 
         if #available(iOS 13.0, *) {
             var actions: [AppcuesExperienceAction] = []