♻️ Update didReceiveNotification argument types

appcues · May 6, 2024 · e1c7ecf · e1c7ecf
1 parent 1a844d9
commit e1c7ecf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Sources/AppcuesKit/Appcues.swift b/Sources/AppcuesKit/Appcues.swift
@@ -337,8 +337,7 @@ public class Appcues: NSObject {
     }
 
     public func didReceiveNotification(response: UNNotificationResponse, completionHandler: @escaping () -> Void) -> Bool {
-        let userInfo = response.notification.request.content.userInfo
-        return container.resolve(PushMonitoring.self).didReceiveNotification(userInfo: userInfo, completionHandler: completionHandler)
+        return container.resolve(PushMonitoring.self).didReceiveNotification(response: response, completionHandler: completionHandler)
     }
 
     func initializeContainer() {

diff --git a/Sources/AppcuesKit/Push/PushMonitor.swift b/Sources/AppcuesKit/Push/PushMonitor.swift
@@ -16,8 +16,7 @@ internal protocol PushMonitoring: AnyObject {
 
     func refreshPushStatus(completion: ((UNAuthorizationStatus) -> Void)?)
 
-    // Using `userInfo` as a parameter to be able to mock notification data.
-    func didReceiveNotification(userInfo: [AnyHashable: Any], completionHandler: @escaping () -> Void) -> Bool
+    func didReceiveNotification(response: UNNotificationResponse, completionHandler: @escaping () -> Void) -> Bool
 }
 
 internal class PushMonitor: PushMonitoring {
@@ -76,7 +75,9 @@ internal class PushMonitor: PushMonitoring {
     }
 
     // `completionHandler` should be called iff the function returns true.
-    func didReceiveNotification(userInfo: [AnyHashable: Any], completionHandler: @escaping () -> Void) -> Bool {
+    func didReceiveNotification(response: UNNotificationResponse, completionHandler: @escaping () -> Void) -> Bool {
+        let userInfo = response.notification.request.content.userInfo
+
         config.logger.info("Push response received:\n%{private}@", userInfo.description)
 
         guard let parsedNotification = ParsedNotification(userInfo: userInfo) else {