Fixed: the CPArrayController addObject: optimization for fast index u…

…pdates would never fire with a nil _filterPredicate, causing rearrangeObjects to be called needlessly.
appden · May 26, 2010 · 6ea2b4e · 6ea2b4e
1 parent f7e2e9c
commit 6ea2b4e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/AppKit/CPArrayController.j b/AppKit/CPArrayController.j
@@ -352,11 +352,11 @@
     if (_clearsFilterPredicateOnInsertion)
         [self setFilterPredicate:nil];
 
-    if ([_filterPredicate evaluateWithObject:object])
+    if (_filterPredicate === nil || [_filterPredicate evaluateWithObject:object])
     {
-        [self willChangeValueForKey:@"selectionIndexes"];
         var pos = [_arrangedObjects insertObject:object inArraySortedByDescriptors:_sortDescriptors];
 
+        [self willChangeValueForKey:@"selectionIndexes"];
         [_selectionIndexes shiftIndexesStartingAtIndex:pos by:1];
         [self didChangeValueForKey:@"selectionIndexes"];
     }