Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark jxl imports optional in OSGi #16

Closed
dkulp opened this issue Jul 29, 2015 · 5 comments
Closed

Mark jxl imports optional in OSGi #16

dkulp opened this issue Jul 29, 2015 · 5 comments
Assignees
@benoitx
Labels
enhancement

Comments

@dkulp
Copy link

dkulp commented Jul 29, 2015

Currently, the jxl imports are not marked as optional in the MANIFEST for the OSGi metadata. This causes a problem for projects wishing to use flatpack for non-Excel use cases as that requires jexcelapi to be installed which is licensed LGPL. For example, Apache projects cannot pull that in. It would be great if those imports can be marked optional.

This would be needed for 3.4.x.
benoitx added a commit that referenced this issue Jul 29, 2015
@benoitx
Fix for #16
04c8c42 
Mark JXL as optional.
benoitx added a commit that referenced this issue Jul 29, 2015
@benoitx
Fix in master for #16
7d16206 
Mark JXL as optional for Manifest.
@benoitx
Copy link
Contributor

benoitx commented Jul 29, 2015

Hi
Could you try the latest 3.4.3-SNAPSHOT in the Snapshot repo?
https://oss.sonatype.org/content/repositories/snapshots/net/sf/flatpack/flatpack/3.4.3-SNAPSHOT/

Let us know if it fixes your issue

Thanks

@benoitx benoitx self-assigned this Jul 29, 2015
@dkulp
Copy link
Author

dkulp commented Jul 29, 2015

Seems to work perfectly. Thanks! (any idea when a release may occur?)

@benoitx
Copy link
Contributor

benoitx commented Jul 29, 2015

I'll check with my colleague.
Soon hopefully we have fixed a couple of items recently.

@benoitx
Copy link
Contributor

benoitx commented Jul 30, 2015

I'll try to push a release this weekend.

@benoitx
Copy link
Contributor

benoitx commented Jul 30, 2015

Please try release 3.4.3 or 4.0.1 (java 8).
Let us know. Thanks

@benoitx benoitx closed this as completed Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitx benoitx

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkulp @benoitx