minor refactoring in sendWeb.js

appfeel · Aug 2, 2019 · a160ed7 · a160ed7
1 parent 6b48ba4
commit a160ed7
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 78 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -72,13 +72,13 @@
     "eslint-plugin-jsx-a11y": "^6.2.3",
     "eslint-plugin-prettier": "^3.1.0",
     "eslint-plugin-react": "^7.14.3",
-    "husky": "^3.0.1",
+    "husky": "^3.0.2",
     "istanbul": "^1.1.0-alpha.1",
     "mocha": "^6.2.0",
     "opn-cli": "^3.1.0",
     "prettier": "^1.18.2",
     "pretty-quick": "^1.11.1",
-    "release-it": "^12.3.4",
+    "release-it": "^12.3.5",
     "sinon": "^1.17.7",
     "sinon-chai": "^3.3.0"
   },

diff --git a/src/sendWeb.js b/src/sendWeb.js
@@ -1,8 +1,11 @@
 const webPush = require('web-push');
+const { is, unless, assoc } = require('ramda');
 const { WEB_METHOD } = require('./constants');
 
+const stringify = unless(is(String), JSON.stringify);
+
 const sendWebPush = async (regIds, data, settings) => {
-  const payload = typeof data === 'string' ? data : JSON.stringify(data);
+  const payload = stringify(data);
   const promises = regIds.map(regId =>
     webPush
       .sendNotification(regId, payload, settings.web)
@@ -36,8 +39,7 @@ const sendWebPush = async (regIds, data, settings) => {
     failure: acc.failure + current.failure,
     message: [...acc.message, ...current.message],
   }));
-  reduced.method = WEB_METHOD;
-  return reduced;
+  return assoc('method', WEB_METHOD, reduced);
 };
 
 module.exports = sendWebPush;