Extracted method that 'detects push method by reg id' #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-friedl
requested changes
Jan 24, 2021
src/push-notifications.js
Outdated
| @@ -42,17 +72,17 @@ class PN { | |||
|
|
|||
| // Classify each pushId for corresponding device | |||
| regIds.forEach((regId) => { | |||
| if (typeof regId === 'object') { | |||
| const pushMetdod = this.getPushMethodByRegId(regId); | |||
| @@ -30,6 +38,28 @@ class PN { | |||
| }); | |||
| } | |||
|
|
|||
| getPushMethodByRegId(regId) { | |||
There was a problem hiding this comment.
please add test in test/push-notifications/basic.js
| @@ -30,6 +38,28 @@ class PN { | |||
| }); | |||
| } | |||
|
|
|||
| getPushMethodByRegId(regId) { | |||
There was a problem hiding this comment.
please add documentation about newly exported function in README.md
- added test and documentation
|
Thanks for your review and sorry for my late response. I tried to address your points and hope it matches your expectations. I am glad to hear from you. |
alex-friedl
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted method that detects device type / used push method out of send method. I will use it for logging / persisting the device type that was used by send() method.