Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed blank title and message #52

Closed
wants to merge 1 commit into from
Closed

Conversation

guns2410
Copy link

@guns2410 guns2410 commented May 7, 2017

This is required for sending out silent notifications. If the title or message field is present, the app treats it as a noisy notification and a blank notification is displayed.

This is required for sending out silent notifications.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 25002db on guns2410:patch-1 into 8035461 on appfeel:master.

@alex-friedl
Copy link
Collaborator

alex-friedl commented May 21, 2017

Hi @guns2410,
just wondering if in that case it would even make sense to never allow title and message to bet set if silent === true? Isn't that what #49 proposes?

@guns2410
Copy link
Author

Yes, that is correct. But ideally if the title or the body is not specified that should mean that it is a silent notification and should remove the title and body fields from the payload.

@leograde
Copy link

I could really use this feature right now. Any ideas when silent notification will be merged?

@alex-friedl
Copy link
Collaborator

I am still not convinced the proposed change is sufficient. From what I read we should make sure that neither, sound nor badge nor alert are set and priority is set to 5?

@alex-friedl
Copy link
Collaborator

Hello @guns2410 , @leograde ,

could you have a look at #83, test the branch and give me feedback if this works for you?
Unfortunately I don't have a working iOS setup.

Thank you!

@alex-friedl
Copy link
Collaborator

Closed in favor of #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants