Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shut down APN client on send completion - fix memory leak #54

Closed
wants to merge 2 commits into from
Closed

Shut down APN client on send completion - fix memory leak #54

wants to merge 2 commits into from

Conversation

shackpank
Copy link
Contributor

Probably related: #47 , #44

The below graph is memory usage of our application, before and after applying this patch
screen shot 2017-06-23 at 08 43 40

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8363a62 on shackpank:master into 8035461 on appfeel:master.

@shackpank
Copy link
Contributor Author

Closing to reopen from a different branch - about to add another patch to the master branch of my fork

@shackpank shackpank closed this Jul 12, 2017
@shackpank shackpank mentioned this pull request Jul 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shackpank @coveralls