Add aria-label to Spinner and ApmSpinner #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable customization of the label by allowing for an optional label prop aria-label defaults to 'loading' unless specified Update Spinner.stories for new functionality
R-Alers
force-pushed
the
stackSpinnerLabel
branch
from
23554c2
to
bfd278a
Compare
|
Released prerelease version |
JeremyRH
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being added
Set the aria-label of the Spinner component to 'loading' by default.
Allow customization of aria-label through the label prop (optional)
Why it is being added
Improve accessibility across apps using the Spinner component
Demo