Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

401 vs 403 #13

Open
cwdcwd opened this issue Aug 17, 2018 · 5 comments
Open

401 vs 403 #13

cwdcwd opened this issue Aug 17, 2018 · 5 comments
Assignees

Comments

@cwdcwd
Copy link
Contributor

cwdcwd commented Aug 17, 2018

There's a couple issues with this line and this line:

  1. the 403 should be const and not a magic number
  2. 403 is reserved for when a user is denied authorization, despite having a valid authentication. 401 is for when authentication is invalid. Good explanation can be read here
@BadalZ
Copy link

BadalZ commented Oct 1, 2018

No more relevant and so closing it out

@BadalZ BadalZ closed this as completed Oct 1, 2018
@cwdcwd
Copy link
Contributor Author

cwdcwd commented Oct 5, 2018

@BadalZ why isn't this relevant any more?

@cwdcwd cwdcwd reopened this Oct 5, 2018
@mtwomey mtwomey assigned mtwomey and sachin-maheshwari and unassigned mtwomey Oct 5, 2018
@sharathkumaranbu
Copy link
Contributor

@sachin-maheshwari Are we planning to fix this issue or not?

@sharathkumaranbu
Copy link
Contributor

@sachin-maheshwari Could we address this as well in the upcoming release? This create lot of inconsistencies in Swagger response vs actual API response

cc @cwdcwd

@cwdcwd
Copy link
Contributor Author

cwdcwd commented Aug 7, 2019

@sachin-maheshwari did we happen to fix this one at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants