Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three unit tests still actually made system calls to
xcrun
. Mock those.@mykola-mokhnach Can you run the existing utils unit tests (
npm run build && npx mocha -R spec build/test/unit/utils-specs.js
) before trying this patch? If the same threeTypeError
errors come up, then that kind of confirms this is the place. Then with this patch those should be gone.That would also confirm that the problem is somewhere in the system call, which sucks. I would suggest at that point going into
teen_process
and trying toexec
thexcrun --sdk iphonesimulator --show-sdk-version
and see where the error comes up.I wish I could reproduce this so I could investigate. :(