Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NSProxy as base class for FBApplicationProcessProxy #109

Merged
merged 1 commit into from Aug 17, 2018

Conversation

fr0l
Copy link

@fr0l fr0l commented Aug 17, 2018

Allows to forward NSKeyValueObserverRegistration methods.

Fixes issue #975 (Facebook's original fork) — Allows to work with Xcode 10 beta 5 and beta 6.

Tested for Xcode 9.4.1 as well

(this PR is cherry-pick of PR 979 to Facebook's WebDriverAgent fork

@jsf-clabot
Copy link

jsf-clabot commented Aug 17, 2018

CLA assistant check
All committers have signed the CLA.

@mykola-mokhnach
Copy link

Thanks @fr0l
Can you please sign the CLA?

@fr0l
Copy link
Author

fr0l commented Aug 17, 2018

@mykola-mokhnach to me it look like I did sign the CLA. is it not so ?

@mykola-mokhnach
Copy link

Now it's ok

@mykola-mokhnach mykola-mokhnach merged commit bb038a6 into appium:master Aug 17, 2018
@fr0l fr0l deleted the xcode10nsproxy branch August 17, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants