Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update XCTestCase proxy to support Xcode 11.4 #286

Merged
merged 3 commits into from Feb 17, 2020
Merged

fix: Update XCTestCase proxy to support Xcode 11.4 #286

merged 3 commits into from Feb 17, 2020

Conversation

mykola-mokhnach
Copy link

@mykola-mokhnach mykola-mokhnach mentioned this pull request Feb 17, 2020
Closed
@mykola-mokhnach mykola-mokhnach changed the title fix: Update XCTestCase proxy to support Xcode 11.4 [WIP] fix: Update XCTestCase proxy to support Xcode 11.4 Feb 17, 2020
KazuCocoa
KazuCocoa approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with Xcode 11.4, iOS 13.4 and iOS 11.4 simulators and /source endpoint. This change worked. Seems good to me.

WebDriverAgentLib/Utilities/FBFailureProofTestCase.m
@@ -23,7 +23,15 @@ - (void)setUp
{
[super setUp];
self.continueAfterFailure = YES;
self.internalImplementation = (_XCTestCaseImplementation *)[FBXCTestCaseImplementationFailureHoldingProxy proxyWithXCTestCaseImplementation:self.internalImplementation];
if ([self respondsToSelector:@selector(internalImplementation)]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about leave a comment Xcode 11.4 no longer have this API in L17 in PrivateHeaders/XCTest/XCTestCase.h ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the codes but the error still exists..... I'm using Xcode 11.4, IOS 11.1. In the WDA file I downloaded, the file FBFailureProofTestCaseTest.m was under path WebDriverAgentTests/IntegrationTests, not WebDriverAgentLib/Utilities. Did I download the wrong file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was WebDriverAgentLib/Utilities/FBFailureProofTestCase.m, not FBFailureProofTestCaseTest.m.
Did you find another issue in FBFailureProofTestCaseTest.m?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It works fine now. Sorry. That was my stupid mistake. Thanks.

@mykola-mokhnach mykola-mokhnach changed the title [WIP] fix: Update XCTestCase proxy to support Xcode 11.4 fix: Update XCTestCase proxy to support Xcode 11.4 Feb 17, 2020
@mykola-mokhnach mykola-mokhnach merged commit bfcb1f0 into master Feb 17, 2020
@mykola-mokhnach mykola-mokhnach deleted the implementation branch February 17, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenneyhuang chenneyhuang chenneyhuang left review comments

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mykola-mokhnach @chenneyhuang @KazuCocoa