refactor: Update snapshotting logic #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the minimum supported Xcode SDK version is bumped to 10.2
…o snapshots # Conflicts: # PrivateHeaders/XCTest/XCUIApplicationProcess.h # WebDriverAgentLib/Categories/XCUIApplication+FBHelpers.m # WebDriverAgentLib/Categories/XCUIApplicationProcess+FBQuiescence.m # WebDriverAgentLib/Categories/XCUIElement+FBUtilities.m # WebDriverAgentLib/Commands/FBSessionCommands.m # WebDriverAgentLib/Utilities/FBConfiguration.h # WebDriverAgentLib/Utilities/FBConfiguration.m # WebDriverAgentLib/Utilities/FBXPath.m
Dan-Maor
approved these changes
Oct 22, 2020
KazuCocoa
reviewed
Oct 22, 2020
| @@ -0,0 +1,34 @@ | |||
| /** | |||
|
Not sure by this or #404 , but I found a scroll scenario failed in https://github.com/appium/ruby_lib_core/blob/7801efa72b10ff3c601374af3e0e7dc68e3c8733/test/functional/ios/webdriver/w3c_actions_test.rb#L44 with the latest beta on CI. (I retried it a couple of times) |
|
Thanks for checking it @KazuCocoa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach tries to align the way we take snapshots with custom attributes to what XCTest does. Also, if a snapshot with custom attributes fails then it is going to fallback to the default one after
customSnapshotTimeoutexpires. This ensures we can always retrieve the same tree that XCTest, but does not ensure same values for custom attributes (like thevisibleone). It is also possible to completely disable custom attributes by settingcustomSnapshotTimeoutto zero in order to avoid any potentially inconsistent results