feat: add result bundle arguments #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(The attached result was part of https://github.com/appium/ruby_lib_core/blob/master/test/functional/ios/patch_test.rb ) |
mykola-mokhnach
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resultBundle has been matured. Our WDA is also getting vanilla XCTest more, so our steps also can record on the result file. It helps debug something or as a record in XCTest framework level.
We can see like below result via
.xcresultfile which is available in a log file. The log file can specify by-resultBundlePath.xcodebuild command has
-resultStreamPath, but I could not find how it works. So, this PR only addsresultBundlePathandresultBundleVersion.resultBundleVersionis 3 by default (and allow only 3 so far) in recent Xcode versions. I'm not sure if the version will provide multiple versions in the future, but it should help to specify the result bundle parameter.In the future, we can provide some options over
xcresulttool.