Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switch search by identifier to use predicates #414

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

mykola-mokhnach
Copy link

Internally search by identifier is anyway changed to predicate search. Also, the current implementation might sometimes be confusing, because the value we show in the page source for name is wdName, which is calculated as

  NSString *identifier = self.identifier;
  if (nil != identifier && identifier.length != 0) {
    return identifier;
  }
  NSString *label = self.label;
  return FBTransferEmptyStringToNil(label);

@mykola-mokhnach
Copy link
Author

Possibly fixes #408 (comment)

…o search

# Conflicts:
#	WebDriverAgentLib/Categories/XCUIElement+FBFind.m
@mykola-mokhnach mykola-mokhnach merged commit 855efc0 into master Oct 27, 2020
@mykola-mokhnach mykola-mokhnach deleted the search branch October 27, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants