feat: Add isAccessible field into element page source representation #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up PR for discussion raised here - appium/appium#15232.
In our use case we would like to run several accessibility checks, relying on the information provided by page source. However, it is difficult to distinguish which elements should be accessible or not (and therefore, should be checked against accessibility checks) without actually having this information inside the tree.
WebDriver allows to grab
isAccessible
field for individual element, on the other hand requesting this data for each element takes immense amount of time.That's why we think that it would be great to expose this field via page source sent by
/source
endpoint. This is the whole purpose of this PR.Feel free to express any thoughts or concerns.