Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xcode warning about com.facebook.wda.lib #892

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

KazuCocoa
Copy link
Member

Fixes below Xcode warning.

    builtin-infoPlistUtility /Users/kazu/GitHub/WebDriverAgent/WebDriverAgentLib/Info.plist -producttype com.apple.product-type.framework -expandbuildsettings -format binary -platform iphoneos -requiredArchitecture arm64 -o /Users/kazu/GitHub/WebDriverAgent/build/Release-iphoneos/WebDriverAgentLib.framework/Info.plist
/Users/kazu/GitHub/WebDriverAgent/WebDriverAgent.xcodeproj: warning: User-supplied CFBundleIdentifier value 'com.facebook.wda.lib' in the Info.plist must be the same as the PRODUCT_BUNDLE_IDENTIFIER build setting value 'com.facebook.WebDriverAgentLib'. (in target 'WebDriverAgentLib' from project 'WebDriverAgent')

My change is via Xcode, thus this diff except for $(PRODUCT_BUNDLE_IDENTIFIER) was by Xcode. I have checked this did not break building for a real device as well.

@KazuCocoa KazuCocoa changed the title fix xcode warning about com.facebook.wda.lib fix: xcode warning about com.facebook.wda.lib Apr 20, 2024
@KazuCocoa KazuCocoa merged commit 6398079 into master Apr 20, 2024
45 of 46 checks passed
@KazuCocoa KazuCocoa deleted the fix-warning branch April 20, 2024 07:16
github-actions bot pushed a commit that referenced this pull request Apr 20, 2024
## [8.5.5](v8.5.4...v8.5.5) (2024-04-20)

### Bug Fixes

* xcode warning about com.facebook.wda.lib ([#892](#892)) ([6398079](6398079))
Copy link

🎉 This PR is included in version 8.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants