fixed setWifiState and setDataState for API>19 #157
Conversation
|
@imurchie @jlipps @TikhomirovSergey Please review. This fixes the API to work on all the Android API till API Level 23 (Tested from 19 to 23) |
| @@ -231,7 +231,6 @@ methods.sendTelnetCommand = async function (command) { | |||
| dataStream += data; | |||
| if (readyRegex.test(data)) { | |||
| res = dataStream.replace(readyRegex, "").trim(); | |||
| res = _.last(res.trim().split('\n')); | |||
There was a problem hiding this comment.
Without this the new Android studio does not work when auto launching the emulator. Is it causing problems?
There was a problem hiding this comment.
Yes with gulp test i was not able to run my code on emulator.But still tested using the adb commands directly through terminal.That works on almost all Android APIs.
There was a problem hiding this comment.
It may need to be more complex, then.
See #150
|
I think this should be two PRs, really. One dealing with the wifi/data, and the other making changes to the locale, language, etc. That one seems to need some justification for doing. |
|
@imurchie I see lot of changes related to locale,languages which are not related to this PR.I will resubmit the PR with all latest pull from upstream.Apologies for confusion. |
|
Raised here: #158 |
This will resolve appium/appium#5256 and this will continue in appium/appium-android-driver#147