Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle remoteAdbHost and remoteAdbPort from desired capabilities #3

Merged
merged 1 commit into from
Jun 4, 2014

Conversation

marley71
Copy link
Contributor

@marley71 marley71 commented Jun 3, 2014

Use remoteAdbHost and remoteAdbPort into desired capabilities variables to set the remote adb server address.

split from as #2250 in submodule adb

sebv added a commit that referenced this pull request Jun 4, 2014
handle remoteAdbHost and remoteAdbPort from desired capabilities
@sebv sebv merged commit af819ab into appium:master Jun 4, 2014
@jlipps
Copy link
Member

jlipps commented Jun 4, 2014

I have the same concerns about this commit as the previous pull request. There is a bug here in that this.adbCmd will be reassigned without taking on the values added here.

@sebv
Copy link
Member

sebv commented Jun 4, 2014

I see, it's easy enough to fix, just store the extra options separately.

@sebv sebv mentioned this pull request Jun 4, 2014
d0lfin added a commit to d0lfin/appium-adb that referenced this pull request Nov 25, 2015
KazuCocoa added a commit to KazuCocoa/appium-adb that referenced this pull request Nov 24, 2017
# This is the 1st commit message:
add skip when on Travis because of unexpcted exception

# This is the commit message appium#2:

move skip to it

# This is the commit message appium#3:

Revert "move skip to it"

This reverts commit f08b0f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants