Speed up permissions detection #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2018 07:40
jlipps
approved these changes
Sep 25, 2018
lib/helpers.js
Outdated
| const titleIndent = lines[0].search(indentPattern); | ||
| const permissionNamePattern = /android\.permission\.\w+/; | ||
| const grantedStatePattern = /\bgranted=(\w+)/; | ||
| const result = []; |
There was a problem hiding this comment.
i know it's valid but it seems weird to push to a const array
lib/tools/adb-commands.js
Outdated
| const stdout = cmdOutput || await this.shell(['dumpsys', 'package', pkg]); | ||
| const grantedPermissions = []; | ||
| for (const pattern of [ | ||
| new RegExp(/^(\s*install permissions:[\s\S]+)/, 'm'), |
There was a problem hiding this comment.
might be more readable to make this array its own const
lib/tools/adb-commands.js
Outdated
| let match = new RegExp(/(install permissions:|User 0)([\s\S]*?)DUMP OF SERVICE activity:/g).exec(stdout); | ||
| if (!match) { | ||
| throw new Error('Unable to get denied permissions'); | ||
| const stdout = cmdOutput || await this.shell(['dumpsys', 'package', pkg]); |
There was a problem hiding this comment.
this is all the same logic as above; maybe factor out one method that just takes a bool to get granted vs denied?
There was a problem hiding this comment.
I don't want to change module interface. And there is also not much content to extract into a common function
|
@jlipps I did some refactoring there and now the amount of redundant code has been slightly decreased. Thanks for the hint |
jlipps
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is the same as for #355
Package manager invocation is more expensive from performance perspective in comparison to dumpsys call