Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI config to include Android 7 (API 24) #359

Merged
merged 2 commits into from
Sep 28, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

android 5 is missing some functional features we need to test

@mykola-mokhnach mykola-mokhnach changed the title Update CI config to include Android 8 (API 27) Update CI config to include Android 7 (API 24) Sep 26, 2018
@@ -1,60 +1,68 @@
language: android
dist: precise
dist: trusty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience Android never works on Travis's "trusty" distribution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is strange, but it works with trusty now

Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when it works

@mykola-mokhnach
Copy link
Contributor Author

Now, finally, after several tens of commits, three days of hard work and four squashes we got our own Travis config with poker and housewives.

Bender

@mykola-mokhnach
Copy link
Contributor Author

@jlipps Can you please check the PR again, as there were quite a lot of changes since the last review?

Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's some crazy bash

@mykola-mokhnach mykola-mokhnach merged commit 8cf9453 into appium:master Sep 28, 2018
@mykola-mokhnach mykola-mokhnach deleted the extend_api branch October 10, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants