simplify changing locale

[KazuCocoa]

Currently, Appium tries to reboot devices when a user change locale since Appium change locales via adb command for API level 23- devices. It doesn't work for real devices without root permission.

We don't need to reboot devices if we change them through io.appium.setting while we need to set language and locale in caps so far. <= breaking change. (We can keep previous spec if we update io.appium.settings)

I ensured this works on Android 4.2(api level 17) and 6.0(api level 23) real devices.

Below log is an example to change locale via persist.sys.locale (but it does not work)

[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell appops set io.appium.settings android\:mock_location allow'
[debug] [ADB] Device API level: 23
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell getprop persist.sys.locale'
[debug] [ADB] Current device property 'persist.sys.locale': ja-JP
[debug] [ADB] Current locale: 'ja-JP'; requested locale: 'en-US'
[debug] [ADB] Device API level: 23
[debug] [ADB] Setting device property 'persist.sys.locale' to 'en-US'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell setprop persist.sys.locale en-US'
[ADB] Rebooting the device in order to apply new locale via 'setting persist.sys.locale' command.
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell stop'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell setprop sys.boot_completed 0'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell start'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell getprop sys.boot_completed'
[debug] [ADB] Current device property 'sys.boot_completed': 1
[debug] [ADB] Device API level: 23
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell getprop persist.sys.locale'
[debug] [ADB] Current device property 'persist.sys.locale': ja-JP
[debug] [AndroidDriver] Shutting down Android driver
[debug] [AndroidDriver] Called deleteSession but bootstrap wasn't active
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s CB5A22LZ79 shell am force-stop io.appium.unlock'

[mykola-mokhnach]

👍