Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android preferences root path on Windows #558

Merged
merged 15 commits into from
Nov 26, 2020

Conversation

jpkleemans
Copy link
Contributor

On Windows avds are stored, by default, in C:\Users\{USER}\.android\avd.

The current version of listEmulators() searches for the avd folder in C:\Users\{USER}\AppData\Local\Android (via getAndroidPrefsRoot()), but that's the wrong location.

By default, the emulator stores configuration files under $HOME/.android/ and AVD data under $HOME/.android/avd/. You can override the defaults by setting the following environment variables. The emulator -avd <avd_name> command searches the avd directory in the order of the values in $ANDROID_AVD_HOME, $ANDROID_SDK_HOME/.android/avd/, and $HOME/.android/avd/.

Source: https://developer.android.com/studio/command-line/variables

lib/helpers.js Outdated Show resolved Hide resolved
@mykola-mokhnach mykola-mokhnach changed the title Fix Android preferences root path on Windows fix: Android preferences root path on Windows Nov 24, 2020
lib/helpers.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments only

@mykola-mokhnach
Copy link
Contributor

mykola-mokhnach commented Nov 26, 2020

Please remove trailing spaces required to make the linter happy: https://travis-ci.org/github/appium/appium-adb/jobs/745830756#L1289 and fix the variable definition: https://travis-ci.org/github/appium/appium-adb/jobs/745830756#L1292

@mykola-mokhnach
Copy link
Contributor

Perfect, thanks for your hard work @jpkleemans

@mykola-mokhnach mykola-mokhnach merged commit 4639390 into appium:master Nov 26, 2020
@jpkleemans
Copy link
Contributor Author

👍 Thanks for your support

@jpkleemans jpkleemans deleted the patch-1 branch November 26, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants