Adding apk-utilities and functional and unit tests for it #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.errorAndThrow("activity and pkg is required for launching application"); | ||
| } | ||
| // initializing defaults | ||
| _.defaults(startAppOptions, { |
There was a problem hiding this comment.
Better clone the options before using defaults. It is modifying startAppOptions.
(https://lodash.com/docs#defaults)
There was a problem hiding this comment.
@jlipps and I discussed this. It ok to modify startAppOptions. What do you think?
There was a problem hiding this comment.
I don't think it's ok, makes it complicate to track side effects.
|
Few comments, otherwise 👍 |
| let apiLevel = await this.getApiLevel(); | ||
| let thirdparty = apiLevel >= 15 ? "-3" : ""; | ||
| let stdout = await this.shell(['pm', 'list', 'packages', thirdparty, pkg]); | ||
| let apkInstalledRgx = new RegExp('^package:' + pkg.replace(/(\.)/g, "\\$1") + |
There was a problem hiding this comment.
Can we use an interpolated string here?
|
In general, looks good! |
moizjv
force-pushed
the
2.0
branch
2 times, most recently
from
26dc7d5
to
4c4fdde
Compare
| log.errorAndThrow("Permission to start activity denied."); | ||
| } | ||
| if (startAppOptions.waitActivity) { | ||
| if (startAppOptions.hasOwnProperty("waitDuration")) { |
There was a problem hiding this comment.
can't we just get rid of this if/else?
await this.waitForActivity(startAppOptions.waitPkg, startAppOptions.waitActivity, startAppOptions.waitDuration);if startAppOptions doesn't have a waitDuration, then it will pass undefined, which is exactly the same thing as not passing it at all.
|
made my comments |
moizjv
added a commit
that referenced
this pull request
Jun 11, 2015
Adding apk-utilities and functional and unit tests for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jlipps @sebv please review.