Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #171, removes unused state.touch parameters #174

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

tiagoshibata
Copy link
Contributor

Fixes #171.
#171 is now crashing on android bootstrap when it receives the first wait without a position. I'll fix appium-android-bootstrap to accept them.

Please don't merge yet, I'll report back when this is fully functional. Let me know if you have any commentaries about this PR.

@imurchie
Copy link
Contributor

Thanks for doing this! How is the work on appium-android-bootstrap going? Anything I can help with?

@tiagoshibata
Copy link
Contributor Author

Hi, I will do a PR for appium-android-bootstrap this weekend. I'll let you know if I have problems.

@tiagoshibata
Copy link
Contributor Author

Hi @imurchie, I couldn't get the maven project to compile. I followed these instructions and got this warning when packaging :

[WARNING] The requested profile "4.4" could not be activated because it does not exist.

I later installed all the API versions and profiles (mvn clean ; mvn install) and got the same warning. Is something else needed for the project to locate the profiles?

mvn help:all-profiles shows no profiles available at the bootstrap directory. I am using maven 3.3.9.

mvn install log

mvn package -P 4.4 log

List of profiles at maven-android-sdk-deployer and bootstrap.

Thanks!

@imurchie
Copy link
Contributor

imurchie commented Aug 2, 2016

Weird.

I would just use ant build from the bootstrap directory, instead of Maven directly.

You can also just run npm install from the root directory of appium-android-bootstrap.

@tiagoshibata
Copy link
Contributor Author

I got compilation working and am doing some changes based on Android's InteractionController. Required changes were a bit larger than I had imagined, I will post back when I have results.

@tiagoshibata
Copy link
Contributor Author

tiagoshibata commented Aug 15, 2016

Hi,

PR at appium-boneyard/appium-android-bootstrap#30. Let me know if you have any suggestions for improvement!

@imurchie
Copy link
Contributor

Can you bump the version of appium-android-bootstrap to a minimum of 2.7.5? Then we can get this going!

@tiagoshibata
Copy link
Contributor Author

Done!

@imurchie
Copy link
Contributor

Awesome! Thank you!

@imurchie imurchie merged commit e89340a into appium:master Aug 24, 2016
@imurchie
Copy link
Contributor

Published in appium-android-driver@1.10.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support touch actions that don't start with press
2 participants