Do not install unlock helper if skipUnlock is set to true #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imurchie
reviewed
Sep 24, 2018
| @@ -632,7 +632,7 @@ helpers.initDevice = async function (adb, opts) { | |||
| if (opts.unicodeKeyboard) { | |||
| defaultIME = await helpers.initUnicodeKeyboard(adb); | |||
| } | |||
| if (_.isUndefined(opts.unlockType)) { | |||
| if (_.isUndefined(opts.unlockType) && !opts.skipUnlock) { | |||
There was a problem hiding this comment.
Do we log somewhere if the user gives an unlock type and sets skipUnlock to true?
There was a problem hiding this comment.
that would be visible when we print capabilities at session startup (who is gonna do such unlogical stuff though?)
There was a problem hiding this comment.
(who is gonna do such unlogical stuff though?)
you're still asking that question after working on appium for so long?
There was a problem hiding this comment.
Yes I still do believe in people...
jlipps
approved these changes
Sep 24, 2018
dpgraham
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help to save time for session init if
skipUnlockcapability is truth