add try/catch to avoid error by pullApk in pushString #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/android-helpers.js
Outdated
| @@ -506,7 +506,12 @@ helpers.pushStrings = async function (language, adb, opts) { | |||
| // clean up remote string.json if present | |||
| await adb.rimraf(remoteFile); | |||
|
|
|||
| const app = opts.app || await adb.pullApk(opts.appPackage, opts.tmpDir); | |||
| let app = ''; | |||
There was a problem hiding this comment.
do not assign app to any value by default
There was a problem hiding this comment.
ah... fs.exists in L511 is https://github.com/appium/appium-support/blob/42a2ab3f605d3cd3f78fe26a609c95790fbab963/lib/fs.js#L23
👍
lib/android-helpers.js
Outdated
| try { | ||
| app = opts.app || await adb.pullApk(opts.appPackage, opts.tmpDir); | ||
| } catch (err) { | ||
| logger.debug(`Failed to pull an apk from '${opts.appPackage}' to '${opts.tmpDir}'. Original error: ${err.message}`); |
There was a problem hiding this comment.
I'd rather change the level to info
mykola-mokhnach
approved these changes
Sep 24, 2018
|
@imurchie Could you take a look at this? |
jlipps
approved these changes
Sep 24, 2018
|
@dpgraham Can you publish incrementing the version when you have time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix appium/appium#11403 (comment)
According to appium/appium#11403 (comment) ,
adb.pullApkcan raise an error.In this PR, I've added try/catch to ignore the error if
adb.pullApkraises an error. Theappkeeps empty in the case.I ensured this change fix the issue: appium/appium#11403 (comment)
related commit is 187c669#diff-97eeab6ebf462ba97a11ee0221ddaf13R509