Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Enter button locator for Samsung devices #458

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Update Enter button locator for Samsung devices #458

merged 2 commits into from
Nov 1, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

dpgraham
dpgraham approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@dpgraham dpgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this feature have an E2E test in place already?

@mykola-mokhnach
Copy link
Contributor Author

No it does not. Is it possible to simulator pin lock in the emulator?

@dpgraham
Copy link
Contributor

dpgraham commented Nov 1, 2018

I think it does, but I won't let that hold up merging this PR.

@mykola-mokhnach mykola-mokhnach merged commit d7c5291 into appium:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgraham dpgraham dpgraham approved these changes

@imurchie imurchie Awaiting requested review from imurchie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mykola-mokhnach @dpgraham