screen off before wake up to clean text field, avoid no element crash #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
commented
Feb 4, 2019
| const el = await driver.findElOrEls('xpath', "//*[contains(@resource-id, 'id/key_enter')]", false); | ||
| await driver.click(util.unwrapElement(el)); | ||
| // Waits a bit for the device to be unlocked | ||
| // Some devices accept the entered key automatically | ||
| await sleep(UNLOCK_WAIT_TIME); |
There was a problem hiding this comment.
When I rushed commands without this wait before pressKeyCode, rarely UI2 sever crashed.
Thus, I leave this and call isScreenLocked after this.
There was a problem hiding this comment.
Please add this note as the comment in the code
lib/unlock-helpers.js
Outdated
| @@ -9,6 +9,8 @@ const PATTERN_UNLOCK = 'pattern'; | |||
| const FINGERPRINT_UNLOCK = 'fingerprint'; | |||
| const UNLOCK_TYPES = [PIN_UNLOCK, PASSWORD_UNLOCK, PATTERN_UNLOCK, FINGERPRINT_UNLOCK]; | |||
| const KEYCODE_NUMPAD_ENTER = '66'; | |||
| const KEYCODE_POWER = '26'; | |||
| const KEYCODE_WAKEUP = '224'; // Can work over API Level 20 | |||
There was a problem hiding this comment.
key codes may be integers
There was a problem hiding this comment.
Either worked fine. I defined as string because of the previous implementation.
I ensured this worked, including KEYCODE_NUMPAD_ENTER, worked as int as well.
lib/unlock-helpers.js
Outdated
| const el = await driver.findElOrEls('xpath', "//*[contains(@resource-id, 'id/key_enter')]", false); | ||
| await driver.click(util.unwrapElement(el)); | ||
| // Waits a bit for the device to be unlocked | ||
| // Some devices accept the entered key without enter key. |
There was a problem hiding this comment.
...accept entering the code without pressing the Enter key
mykola-mokhnach
approved these changes
Feb 5, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to pin unlock:
To avoid the error, I did:
KEYCODE_POWERbefore wake upKEYCODE_NUMPAD_ENTERwhen we tap enter keyid/key_enterKEYCODE_NUMPAD_ENTERafter checking screen lockI tested:
They worked well than before. I'm not sure this can cover all of android devices though...
(I have no mush Chinese devices, for example..)