Add server feature to enable automated Chromedriver downloads #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umutuzgur
reviewed
Jun 30, 2019
umutuzgur
reviewed
Jun 30, 2019
| @@ -329,6 +332,18 @@ async function getChromedriverPort (portSpec) { | |||
| return foundPort; | |||
| } | |||
|
|
|||
| helpers.isChromedriverAutodownloadEnabled = function isChromedriverAutodownloadEnabled () { | |||
There was a problem hiding this comment.
I think it should be isChromedriverAutoDownloadEnabled but it doesn't matter. I just wanted to comment in case it was a typo
umutuzgur
approved these changes
Jun 30, 2019
umutuzgur
reviewed
Jun 30, 2019
lib/commands/context.js
Outdated
| @@ -353,6 +368,7 @@ helpers.setupNewChromedriver = async function setupNewChromedriver (opts, curDev | |||
| bundleId: opts.chromeBundleId, | |||
| useSystemExecutable: opts.chromedriverUseSystemExecutable, | |||
| disableBuildCheck: opts.chromedriverDisableBuildCheck, | |||
| isAutodownloadEnabled: this.isChromedriverAutodownloadEnabled(), | |||
There was a problem hiding this comment.
I actually have a concern now. How should this feature work when mappingPath and executableDir are set? Should we set isAutodownloadEnabled to false if they are passed?
There was a problem hiding this comment.
jlipps
approved these changes
Jul 1, 2019
lib/commands/context.js
Outdated
| @@ -329,6 +332,18 @@ async function getChromedriverPort (portSpec) { | |||
| return foundPort; | |||
| } | |||
|
|
|||
| helpers.isChromedriverAutodownloadEnabled = function isChromedriverAutodownloadEnabled () { | |||
| try { | |||
| this.ensureFeatureEnabled(CHROMEDRIVER_AUTODOWNLOAD_FEATURE); | |||
There was a problem hiding this comment.
you can use isFeatureEnabled if you just want the boolean value instead of using try/catch...
KazuCocoa
added a commit
to appium/appium
that referenced
this pull request
Jul 3, 2019
9 tasks
KazuCocoa
added a commit
to appium/appium
that referenced
this pull request
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on appium/appium-chromedriver#131
Please do not merge until the above PR is published