Fix time zone formatting for device time getter #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Aug 5, 2019
imurchie
approved these changes
Aug 5, 2019
KazuCocoa
approved these changes
Aug 5, 2019
| const deviceTimestamp = (await this.adb.shell(['date', '+%Y-%m-%dT%T%z'])).trim(); | ||
| const parsedTimestamp = moment(deviceTimestamp, 'YYYY-MM-DDTHH:mm:ssZ'); | ||
| log.debug(`Got device timestamp: ${deviceTimestamp}`); | ||
| const parsedTimestamp = moment.utc(deviceTimestamp, 'YYYY-MM-DDTHH:mm:ssZZ'); |
There was a problem hiding this comment.
(kind of question)
Can we apply only one Z insteaf of ZZ in JS?
> m.utc(a, 'YYYY-MM-DDTHH:mm:ssZ').toString()
'Sat Jun 09 2018 07:21:54 GMT+0000'
> m.utc(a, 'YYYY-MM-DDTHH:mm:ssZZ').toString()
'Sat Jun 09 2018 07:21:54 GMT+0000'
There was a problem hiding this comment.
ZZ means time zone in format +0000 and Z equals to +00:00. Although, I assume moment parser is smart enough to properly parse the stamp in both cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default moment.js uses the local time zone. And we need to enforce the device time zone to be used while formatting the resulting stamp.
Addresses https://discuss.appium.io/t/driver-getdevicetime-works-incorrectly-for-appium-1-7-2/27369/3