Fix toggle_location_services not working on android 9.0 devices #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
imurchie
approved these changes
Dec 20, 2019
|
@gillett-hernandez Is there any chance to finish the PR? |
refactor to use constants instead of magic numbers
|
@mykola-mokhnach i gave it a shot but i'm a bit rusty on my javascript. let me know if what i wrote as a refactor is not the right way to do it. |
tweak refactor to use consts instead of normal variables
remove unnecessary comments
|
@mykola-mokhnach updated. CI is running now. if it looks good to you, i'd love for it to be merged. |
|
https://travis-ci.org/appium/appium-android-driver/jobs/634469166#L3293 Please add the missing semicolon to make tests pass |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfortunately i haven't been able to test this end to end
i did test by manually inputting the adb keycode sequence and it toggled the location
this potentially fixes appium/appium#13755