feat: Add a possibility to pass a letter as a platformVersion #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imurchie
reviewed
Feb 24, 2020
| partialMatchCandidate = {[device.udid]: deviceOS}; | ||
| } | ||
| if ((!_.includes(opts.platformVersion, '.') && platformVersion.major === deviceOS.major | ||
| || platformVersion.major === deviceOS.major && platformVersion.minor === deviceOS.minor) |
There was a problem hiding this comment.
Should there be some extra parentheses in here? I'm trying to parse this condition and it is confusing.
There was a problem hiding this comment.
no parentheses needed, AND has priority over OR. The meaning of this particular expression is:
- if we don't have a dot in platformVersion then only compare major numbers
- otherwise compare both major and minor version numbers
- if any of the conditions above is truthy then bump our candidate if needed ( e.g. the current candidate is not assigned yet or its version is older than the current deviceOS version)
KazuCocoa
approved these changes
Feb 24, 2020
| if (util.compareVersions(deviceOS, '==', platformVersion)) { | ||
| const bothVersionsCanBeCoerced = semver.valid(deviceOS) && semver.valid(platformVersion); | ||
| const bothVersionsAreStrings = _.isString(deviceOS) && _.isString(platformVersion); | ||
| if (bothVersionsCanBeCoerced && deviceOS.version === platformVersion.version |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/appium#13983