This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Make proxy convert /property to /attribute #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Mar 29, 2019
|
the linter is not very happy tho |
imurchie
reviewed
Mar 29, 2019
.travis.yml
Outdated
| @@ -2,6 +2,7 @@ language: node_js | |||
| node_js: | |||
| - "8" | |||
| - "10" | |||
| - "11" | |||
There was a problem hiding this comment.
This is not really necessary. 11 is a stop-gap that will be EOL-ed in a couple of months.
In a couple of weeks, when 12 is released, we will update everything and drop support for 8.
jlipps
approved these changes
Mar 29, 2019
KazuCocoa
approved these changes
Mar 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After digging into appium/appium#12218 I think the best solution is to proxy W3C
/property/:propcommands through to JSONWP as/attribute/:attr.So, for example, if a W3C session has this endpoint called
GET: /session/123/element/456/property/valueand it's being proxied to a JSONWP server, it should be proxied as
GET: /session/123/element/456/attribute/value