This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Update the logic that determines the session protocol #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Jul 18, 2019
KazuCocoa
approved these changes
Jul 18, 2019
dpgraham
approved these changes
Jul 18, 2019
|
Makes sense. Added the explanation comment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be that we proxy /status call first to the downstream driver and it responds in W3C style (since this is a default setting), but then after createSession request is sent the photo is changed to JSONWP based on the provided caps. This change should properly handle such scenario.