This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
fix: Return proper responses to unexpected errors #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Sep 8, 2020
|
@jlipps According to what I see in clients all of them are only expecting JSON responses. |
|
@jlipps Could you also help fixing https://travis-ci.org/github/appium/appium-base-driver/jobs/725344616#L1804 (perhaps in the other PR). I have a feeling these tests were broken before, so I just skip them for now. |
|
sure, will take a look |
KazuCocoa
approved these changes
Sep 9, 2020
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All clients expect responses to be returned as valid json objects and throw exceptions in case of plain text: https://gist.github.com/TransmitTomerDavid/31132cd2ea3ce3c4514e24494ad8f504