This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
fix: 10 minute connection timeout is too low for some use cases #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Dec 8, 2020
jlipps
force-pushed
the
jlipps-timeout-fix-master
branch
from
9314e41
to
8908a5a
Compare
mykola-mokhnach
suggested changes
Dec 8, 2020
There was a problem hiding this comment.
I would not do that. The idea is that this timeout should not be greater than the default OS timeout, which is 7200 seconds by default in most of the popular operating systems https://www.veritas.com/support/en_US/article.100028680
Consider making it configurable rather than changing the default value.
|
@mykola-mokhnach it is still less than 7200 secs. but making it configurable is a good idea for sure. |
jlipps
force-pushed
the
jlipps-timeout-fix-master
branch
from
8908a5a
to
9ec1a81
Compare
|
ok @mykola-mokhnach i made it configurable. now will update the main appium server with an arg |
mykola-mokhnach
approved these changes
Dec 8, 2020
|
published in 7.4.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone reported a bug where they tried to background the app for 30 minutes and it didn't work. Now we know why!