Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

adding fingerprint to routes #74

Merged
merged 1 commit into from Sep 12, 2016
Merged

Conversation

alizelzele
Copy link
Contributor

requires : adding fingerprint command to work.

@alizelzele
Copy link
Contributor Author

it will solve the issue Requires fingerprint supporting

@imurchie
Copy link
Contributor

imurchie commented Sep 9, 2016

Please run the unit tests locally (using gulp once). Changes to the protocol require changing a hash value in one of the tests.

Otherwise, this seems reasonable. Thanks!

@alizelzele alizelzele force-pushed the finger-print branch 2 times, most recently from e2cf8a3 to ba2ab21 Compare September 12, 2016 01:51
@alizelzele
Copy link
Contributor Author

@imurchie I was not able to npm install at that moment. (google is filtered here !! ) 😄
Sorry for pushing the code without running tests.

@imurchie
Copy link
Contributor

Thanks!

@imurchie imurchie merged commit 590e7cf into appium:master Sep 12, 2016
@imurchie
Copy link
Contributor

Published in appium-base-driver@2.0.15.

@alizelzele alizelzele deleted the finger-print branch September 14, 2016 01:31
KazuCocoa pushed a commit to KazuCocoa/appium-base-driver that referenced this pull request Apr 30, 2019
…m#74)

* reject image template matches below a threshold of default 0.5

* add test of match threshold
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants