Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: attached sessions getting timeout due to inactivity #1726

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix: attached sessions getting timeout due to inactivity #1726

merged 1 commit into from
Mar 15, 2021

Conversation

huzaifaiftikhar
Copy link
Contributor

  1. Attached sessions were getting timeout due to inactivity as we were not displaying the "Session Inactive" prompt to the user in case of an attached session.
  2. This PR fixes the above issue and we start the runKeepAliveLoop similar to what we were doing for a regular session here.

@huzaifaiftikhar
Copy link
Contributor Author

@KazuCocoa Is it possible for you to review this?

@KazuCocoa KazuCocoa self-requested a review March 9, 2021 22:48
@KazuCocoa
Copy link
Member

Will take a look at PRs this weekend

@KazuCocoa KazuCocoa merged commit e407bd7 into appium:1.20 Mar 15, 2021
@huzaifaiftikhar huzaifaiftikhar deleted the fix_idle_timeout_for_attach_to_session branch March 15, 2021 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@huzaifaiftikhar @KazuCocoa