Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass version of SDK, Android build tools and appium through travis #49

Closed
budtmo opened this issue Jun 14, 2017 · 3 comments
Closed

Pass version of SDK, Android build tools and appium through travis #49

budtmo opened this issue Jun 14, 2017 · 3 comments
Labels
enhancement

Comments

@budtmo
Copy link
Member

budtmo commented Jun 14, 2017

Pass version of SDK, Android build tools and Appium through travis and use those as build-args to avoid a commit that only contains version changes of those dependencies.
@andrcuns
Copy link
Contributor

Wouldn't You still have to commit to .travis.yml either way? :)

@budtmo
Copy link
Member Author

budtmo commented Jun 14, 2017

No, because the environment variables option is under settings in travis CI. @andrcuns but we need to create release tag for that so the image is pushed, otherwise it will build the new image without pushing it to docker hub.

@andrcuns
Copy link
Contributor

After I wrote the comment, I remembered that one can configure env variables in travis CI :)

budtmo added a commit to budtmo/appium-docker-android that referenced this issue Jun 15, 2017
@budtmo
Using some parameters from travis as build-args to fix issue appium#49
a5882a2
@budtmo budtmo mentioned this issue Jun 15, 2017
Merged
SrinivasanTarget pushed a commit that referenced this issue Jun 16, 2017
@budtmo @SrinivasanTarget
Clean up build process (#50)
5ff91c6 
* Using some parameters from travis as build-args to fix issue #49

* Push docker image to docker hub only if there is release tag for it

* Deleted new line char because it does not seem to work on travis.yml
@budtmo budtmo closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrcuns @budtmo