Skip to content

Commit

Permalink
chore: bump android driver (#989)
Browse files Browse the repository at this point in the history
  • Loading branch information
mykola-mokhnach committed Mar 19, 2024
1 parent e094c26 commit ea064aa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 38 deletions.
31 changes: 0 additions & 31 deletions lib/commands/app-management.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,5 @@
import { errors } from 'appium/driver';
import { qualifyActivityName, requireOptions } from '../utils';

/**
* @this {import('../driver').EspressoDriver}
*/
// eslint-disable-next-line require-await
export async function launchApp () {
throw new errors.UnsupportedOperationError(
'Please create a new session in order to launch the application under test'
);
}

/**
* @typedef {Object} BackgroundAppOptions
* @property {number} [seconds] The amount of seconds to wait between putting the app to background and restoring it.
Expand All @@ -30,26 +19,6 @@ export async function mobileBackgroundApp (opts = {}) {
return await this.background(seconds);
}

/**
* @this {import('../driver').EspressoDriver}
*/
// eslint-disable-next-line require-await
export async function closeApp () {
throw new errors.UnsupportedOperationError(
'Please quit the session in order to close the application under test'
);
}

/**
* @this {import('../driver').EspressoDriver}
*/
// eslint-disable-next-line require-await
export async function reset () {
throw new errors.UnsupportedOperationError(
'Please quit the session and create a new one ' +
'in order to close and launch the application under test');
}

/**
* @overload
* @typedef {Object} StartActivityOptions
Expand Down
9 changes: 3 additions & 6 deletions lib/driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -667,19 +667,19 @@ export class EspressoDriver extends AndroidDriver implements ExternalDriver<
// settings to the espresso server already
}

// eslint-disable-next-line no-unused-vars
// eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
proxyActive (sessionId) {
// we always have an active proxy to the espresso server
return true;
}

// eslint-disable-next-line no-unused-vars
// eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
canProxy (sessionId) {
// we can always proxy to the espresso server
return true;
}

// eslint-disable-next-line no-unused-vars
// eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
getProxyAvoidList (sessionId) {
// we are maintaining two sets of NO_PROXY lists, one for chromedriver(CHROME_NO_PROXY)
// and one for Espresso(NO_PROXY), based on current context will return related NO_PROXY list
Expand All @@ -702,9 +702,6 @@ export class EspressoDriver extends AndroidDriver implements ExternalDriver<

executeMobile = executeCmds.executeMobile;

launchApp = appManagementCmds.launchApp;
closeApp = appManagementCmds.closeApp;
reset = appManagementCmds.reset;
mobileBackgroundApp = appManagementCmds.mobileBackgroundApp;
startActivity = appManagementCmds.startActivity;
mobileStartActivity = appManagementCmds.mobileStartActivity;
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
],
"dependencies": {
"appium-adb": "^12.0.0",
"appium-android-driver": "^9.0.0",
"appium-android-driver": "^9.0.3",
"asyncbox": "^3.0.0",
"bluebird": "^3.5.0",
"io.appium.settings": "^5.7.2",
Expand Down

0 comments on commit ea064aa

Please sign in to comment.