Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream xml to a file rather than to a memory #344

Merged
merged 7 commits into from
Dec 12, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

Another try to address #340

Copy link
Contributor

@dpgraham dpgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

SystemClock.uptimeMillis() - startTime, streamType.getSimpleName()));
} catch (OutOfMemoryError e) {
lastError = e;
continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever, i like it!

@appium appium deleted a comment Dec 12, 2018
@appium appium deleted a comment Dec 12, 2018
@appium appium deleted a comment Dec 12, 2018
@appium appium deleted a comment Dec 12, 2018
@mykola-mokhnach mykola-mokhnach merged commit 9c88097 into appium:master Dec 12, 2018
@mykola-mokhnach mykola-mokhnach deleted the write_file branch December 12, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants